[LinkTest] Fix speed change (200G->400g) test issue#969
Open
Rancho333-CLS wants to merge 2 commits intofacebook:mainfrom
Open
[LinkTest] Fix speed change (200G->400g) test issue#969Rancho333-CLS wants to merge 2 commits intofacebook:mainfrom
Rancho333-CLS wants to merge 2 commits intofacebook:mainfrom
Conversation
Contributor
|
Thank you for the fix. Which platform is this for? |
Contributor
Author
|
In theory, this can be reproduced on all platforms, as long as the number of logical ports decreases after a speed change. I discovered and fixed it on IceCube. |
| // updated | ||
| applyNewConfig(newConfig); | ||
|
|
||
| updateCablePorts(); |
Contributor
There was a problem hiding this comment.
Let's leave a comment above this line that we need to update cabled ports since the previous speed change may add or remove ports
… why it is needed
harshitgulati18
approved these changes
Mar 3, 2026
|
@harshitgulati18 has imported this pull request. If you are a Meta employee, you can view this in D95063445. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
The AgentEnsembleSpeedChangeTest.TWOHUNDREDGToFOURHUNDREDG test case in the link test failed.
The root cause is that after the flex port configuration is applied, the variable cablePorts_ is not updated. As a result , FBOSS attempts to access ports that have already been removed, which leads to a crash.
For example, a port is configured in 8x200G mode, with port IDs 1, 2, 3, 4, 5, 6, 7, and 8.
After performing a speed change to switch it to 2x400G mode, only port IDs 1 and 5 remain.
However, since cabledPorts_ is not updated, the system still attempts to check the non-existent ports 2, 3, 4, 6, 7, and 8.
Updating the cabledPorts_ variable after applying the new configuration resolves the issue.
Test Plan
All the
pre-commit runchecks have passed.After rebuilding the sai_mono_link_test-sai_impl binary, the test result is PASSED.
Please find the complete test log here.